Updated regex for slot_ibm to include optional -R\d+ segment. by maramsmurthy · Pull Request #6246 · avocado-framework/avocado

maramsmurthy · 2025-11-27T16:57:24Z

This allows matching both standard and extended slot formats: Standard: U50EE.001.WZS00TL-P3-C14
Extended: U50EE.001.WZS00TL-P3-C14-R1
Change ensures compatibility with newer hardware naming conventions that include resource identifiers after the slot number. Backward Compatibility:

Existing slot formats without -R remain fully supported. No impact on current parsing logic for standard slot names. Testing Impact:

Verified regex against both formats to ensure correct matching. Additional unit tests recommended for extended slot names to prevent regressions.

Summary by CodeRabbit

Bug Fixes
- Improved PCI slot detection to support additional IBM hardware device code format variations with optional suffixes, enhancing compatibility with a broader range of systems.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-11-27T16:57:42Z

Walkthrough

A regex pattern in the get_slot_from_sysfs function of avocado/utils/pci.py was modified to extend IBM loc-code slot pattern matching. The pattern was updated to optionally accept a trailing "-R" suffix by adding a non-capturing optional group (?:-R\d+)? to the existing pattern. The modification preserves all existing matches while enabling matching of IBM loc-code strings with the additional suffix. The remainder of the control flow logic remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5-10 minutes

Verify the regex pattern correctly matches both with and without the "-R" suffix
Confirm backward compatibility with existing IBM loc-code strings that lack the suffix
Review the optional group syntax (?:-R\d+)? to ensure it captures the intended pattern

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: a regex update to accept an optional -R\d+ segment in the IBM slot pattern.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74b7379 and 9cc6d14.

📒 Files selected for processing (1)

avocado/utils/pci.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (43)

GitHub Check: rpm-build:fedora-41-ppc64le
GitHub Check: rpm-build:fedora-41-x86_64
GitHub Check: rpm-build:fedora-42-x86_64
GitHub Check: rpm-build:fedora-41-s390x
GitHub Check: rpm-build:fedora-41-aarch64
GitHub Check: rpm-build:centos-stream-9-x86_64
GitHub Check: rpm-build:fedora-43-x86_64
GitHub Check: rpm-build:fedora-rawhide-x86_64
GitHub Check: rpm-build:epel-9-x86_64
GitHub Check: rpm-build:fedora-43-x86_64
GitHub Check: rpm-build:centos-stream-9-x86_64
GitHub Check: rpm-build:fedora-41-aarch64
GitHub Check: rpm-build:fedora-42-x86_64
GitHub Check: rpm-build:epel-9-x86_64
GitHub Check: rpm-build:fedora-41-ppc64le
GitHub Check: rpm-build:fedora-41-s390x
GitHub Check: rpm-build:fedora-41-x86_64
GitHub Check: rpm-build:fedora-rawhide-x86_64
GitHub Check: Linux with Python 3.13
GitHub Check: Linux with Python 3.9
GitHub Check: Linux with Python 3.11
GitHub Check: Linux with Python 3.10
GitHub Check: Linux with Python 3.12
GitHub Check: rpm-build:fedora-41-aarch64
GitHub Check: rpm-build:centos-stream-9-x86_64
GitHub Check: rpm-build:fedora-42-x86_64
GitHub Check: rpm-build:epel-9-x86_64
GitHub Check: rpm-build:fedora-41-s390x
GitHub Check: rpm-build:fedora-41-x86_64
GitHub Check: rpm-build:fedora-43-x86_64
GitHub Check: rpm-build:fedora-rawhide-x86_64
GitHub Check: rpm-build:fedora-41-ppc64le
GitHub Check: Build Package (wheel/tarball) for Python 3.10
GitHub Check: Fedora selftests
GitHub Check: Version task ubi:8.8
GitHub Check: macOS with Python 3.11
GitHub Check: Windows with Python 3.13
GitHub Check: Version task debian:12.4
GitHub Check: Windows with Python 3.11
GitHub Check: Windows with Python 3.10
GitHub Check: Version task ubuntu:22.04
GitHub Check: Static checks
GitHub Check: Code Coverage (3.11)

🔇 Additional comments (1)

avocado/utils/pci.py (1)

203-205: Regex extension looks correct and backward‑compatible

The added optional non‑capturing group (?:-R\d+)? cleanly extends the IBM loc‑code pattern to cover the -R<digits> suffix while preserving all existing matches and group numbering (since it’s non‑capturing). Given the complexity of this regex and its importance, please ensure we also add/extend unit tests to cover examples like U50EE.001.WZS00TL-P3-C14-R1 (and still cover the legacy ...-P3-C14 case) so regressions are caught going forward.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

Provide your own instructions using the high_level_summary_instructions setting.
Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

📝 Description — Summarize the main change in 50–60 words, explaining what was done.

📓 References — List relevant issues, discussions, documentation, or related PRs.

📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.

📊 Contributor Summary — Include a Markdown table showing contributions:
| Contributor | Lines Added | Lines Removed | Files Changed |

✔️ Additional Notes — Add any extra reviewer context.
Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-11-27T17:12:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.31%. Comparing base (48854e8) to head (f560230).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6246   +/-   ##
=======================================
  Coverage   72.31%   72.31%           
=======================================
  Files         206      206           
  Lines       23258    23258           
=======================================
  Hits        16818    16818           
  Misses       6440     6440

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

PraveenPenguin

LGTM

clebergnu

@maramsmurthy thanks for this contribution. Could you please:

Put an (external) reference to the format of the extended version of the identifiers
Add a test that matches both old and new (extended) versions

Thanks!

maramsmurthy · 2026-03-03T12:50:25Z

@clebergnu Following is the output for both the formats of. physical slot

from avocado.utils import pci
pci.get_slot_from_sysfs("0153:70:00.0")
'U78CD.001.FZHAK92-P2-C3'
pci.get_slot_from_sysfs("05b4:90:00.0")
'U50EE.001.WZS0011-P3-C20-R1'

Update worked successfully without any issues

This allows matching both standard and extended slot formats: Standard: U50EE.001.WZS00TL-P3-C14 Extended: U50EE.001.WZS00TL-P3-C14-R1 Change ensures compatibility with newer hardware naming conventions that include resource identifiers after the slot number. Backward Compatibility: Existing slot formats without -R remain fully supported. No impact on current parsing logic for standard slot names. Testing Impact: Verified regex against both formats to ensure correct matching. Additional unit tests recommended for extended slot names to prevent regressions. Signed-off-by: Maram Srimannarayana Murthy <msmurthy@linux.vnet.ibm.com>

Signed-off-by: Maram Srimannarayana Murthy <msmurthy@linux.vnet.ibm.com>

U78CC.001.FZHAK92-P2-C3 which is exisitng format U50EE.001.WZS0011-P3-C20-R1 which is new format We are maitatining both the formats as both formats are required. Both are returning expected output without any issues. Signed-off-by: Maram Srimannarayana Murthy <msmurthy@linux.vnet.ibm.com>

Fixed 'Unexpected indentation' error in ReadTheDocs build by properly formatting the Examples section in reStructuredText format using double colon (::) and proper indentation. Error was: /home/docs/.../avocado/utils/pci.py:docstring of avocado.utils.pci.get_slot_from_sysfs:10: ERROR: Unexpected indentation. Signed-off-by: Maram Srimannarayana Murthy <msmurthy@linux.vnet.ibm.com>

maramsmurthy · 2026-04-27T18:39:11Z

@clebergnu Can you please have a look at this and let me know if any changes are still required?

maramsmurthy · 2026-04-28T04:34:29Z

@maramsmurthy thanks for this contribution. Could you please:

Put an (external) reference to the format of the extended version of the identifiers

Add a test that matches both old and new (extended) versions

Thanks!

@clebergnu Can you please have a look and let me know if any changes are still required?

Naresh-ibm · 2026-05-08T11:21:13Z

@clebergnu can you please review this and approve if no more review comments, as we need this changes to get incorporated into our testing through misc-tests.
early help is really appreciated

Naresh-ibm

LGTM

maramsmurthy · 2026-05-11T04:19:44Z

@clebergnu I’d be grateful if you could review this PR when it’s convenient for you. Thank you for your time, and I’m happy to address any feedback.

PraveenPenguin · 2026-05-11T04:35:56Z

@clebergnu I’d be grateful if you could review this PR when it’s convenient for you. Thank you for your time, and I’m happy to address any feedback.

@clebergnu @richtja can you please review this PR and ublock us

maramsmurthy · 2026-05-14T06:50:12Z

@clebergnu or @richtja we need your help here, Can you please review and approve if no changes are required.

mr-avocado Bot added this to Default project Nov 27, 2025

mr-avocado Bot moved this to Review Requested in Default project Nov 27, 2025

clebergnu requested a review from richtja December 4, 2025 13:53

PraveenPenguin approved these changes Dec 8, 2025

View reviewed changes

clebergnu requested changes Dec 9, 2025

View reviewed changes

maramsmurthy force-pushed the smaram_physical_port_regex_update branch from 0c3f452 to 32943e3 Compare March 3, 2026 17:09

maramsmurthy force-pushed the smaram_physical_port_regex_update branch from 32943e3 to e874659 Compare April 27, 2026 17:44

maramsmurthy added 4 commits April 27, 2026 23:30

Added example of return slots formats in doc string

d55e440

Updated exmples of physical slot formats and added signature to commit

1a4aa73

Signed-off-by: Maram Srimannarayana Murthy <msmurthy@linux.vnet.ibm.com>

maramsmurthy force-pushed the smaram_physical_port_regex_update branch from e874659 to 916d4f5 Compare April 27, 2026 18:01

maramsmurthy requested a review from clebergnu May 4, 2026 10:39

Naresh-ibm approved these changes May 8, 2026

View reviewed changes

PraveenPenguin merged commit f560230 into avocado-framework:master May 18, 2026
12 checks passed

github-project-automation Bot moved this from Review Requested to Done 114 in Default project May 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated regex for slot_ibm to include optional -R\d+ segment.#6246

Updated regex for slot_ibm to include optional -R\d+ segment.#6246
PraveenPenguin merged 5 commits into
avocado-framework:masterfrom
maramsmurthy:smaram_physical_port_regex_update

maramsmurthy commented Nov 27, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

PraveenPenguin left a comment

Uh oh!

clebergnu left a comment

Uh oh!

maramsmurthy commented Mar 3, 2026

Uh oh!

maramsmurthy commented Apr 27, 2026

Uh oh!

maramsmurthy commented Apr 28, 2026

Uh oh!

Naresh-ibm commented May 8, 2026

Uh oh!

Naresh-ibm left a comment

Uh oh!

maramsmurthy commented May 11, 2026

Uh oh!

PraveenPenguin commented May 11, 2026

Uh oh!

maramsmurthy commented May 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

maramsmurthy commented Nov 27, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Pre-merge checks

Uh oh!

codecov Bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PraveenPenguin left a comment

Choose a reason for hiding this comment

Uh oh!

clebergnu left a comment

Choose a reason for hiding this comment

Uh oh!

maramsmurthy commented Mar 3, 2026

Uh oh!

maramsmurthy commented Apr 27, 2026

Uh oh!

maramsmurthy commented Apr 28, 2026

Uh oh!

Naresh-ibm commented May 8, 2026

Uh oh!

Naresh-ibm left a comment

Choose a reason for hiding this comment

Uh oh!

maramsmurthy commented May 11, 2026

Uh oh!

PraveenPenguin commented May 11, 2026

Uh oh!

maramsmurthy commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

maramsmurthy commented Nov 27, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Nov 27, 2025 •

edited

Loading

codecov Bot commented Nov 27, 2025 •

edited

Loading

maramsmurthy commented May 14, 2026 •

edited

Loading